[PATCH] D29622: Add a batch query and replace tool based on AST matchers.

[Manuel Klimek via Phabricator via cfe-commits]

klimek added inline comments.


================
Comment at: clang-query/QueryReplace.cpp:50
+
+void QueryReplaceTool::addOperation(clang::query::QueryReplaceSpec &Spec) {
+  ast_matchers::dynamic::Diagnostics Diag;
----------------
Shouldn't that also just return the error?


================
Comment at: clang-query/QueryReplace.h:35-36
+
+  /// \brief Replacement text. %"identifier" will be substituted by the text of
+  /// an identifier.
+  std::string ToTemplate;
----------------
This doesn't seem to come up in the test? (and I don't understand what it's trying to tell me :)


https://reviews.llvm.org/D29622