r294195 - [OpenMP] Remove fixme comment in regression test and related unnecessary statement

Carlo Bertolli via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 08:03:41 PST 2017


Author: cbertol
Date: Mon Feb  6 10:03:41 2017
New Revision: 294195

URL: http://llvm.org/viewvc/llvm-project?rev=294195&view=rev
Log:
[OpenMP] Remove fixme comment in regression test and related unnecessary statement

https://reviews.llvm.org/D29501

It looks like I forgot to remove a FIXME comment with the associated statement. The test does not need it and it gives the wrong impression of being an incomplete test.


Modified:
    cfe/trunk/test/OpenMP/distribute_lastprivate_codegen.cpp

Modified: cfe/trunk/test/OpenMP/distribute_lastprivate_codegen.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/OpenMP/distribute_lastprivate_codegen.cpp?rev=294195&r1=294194&r2=294195&view=diff
==============================================================================
--- cfe/trunk/test/OpenMP/distribute_lastprivate_codegen.cpp (original)
+++ cfe/trunk/test/OpenMP/distribute_lastprivate_codegen.cpp Mon Feb  6 10:03:41 2017
@@ -229,8 +229,6 @@ int main() {
 // the distribute loop
 // CHECK: call void @__kmpc_for_static_init_4(
 // assignment: vec[i] = t_var;
-// the following is extremely weak, because it assumes ordering of this load with no reference after the call to static_init: fix!!!!
-// CHECK: [[IV_VAL:%.+]] =
 // CHECK: [[T_VAR_PRIV_VAL:%.+]] = load i{{[0-9]+}}, i{{[0-9]+}}* [[T_VAR_PRIV]],
 // CHECK: [[VEC_PTR:%.+]] = getelementptr inbounds [2 x i{{[0-9]+}}], [2 x i{{[0-9]+}}]* [[VEC_PRIV]], i{{[0-9]+}} 0, i{{[0-9]+}} {{.+}}
 // CHECK:  store i{{[0-9]+}} [[T_VAR_PRIV_VAL]], i{{[0-9]+}}* [[VEC_PTR]],




More information about the cfe-commits mailing list