[PATCH] D29267: [clang-tidy] safety-no-assembler

Jonathan B Coe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 02:54:15 PST 2017


jbcoe marked an inline comment as done.
jbcoe added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:32
+
+  diag(ASM->getAsmLoc(), "'%0' is an inline assembler statement") << SourceText;
+}
----------------
aaron.ballman wrote:
> The diagnostic text doesn't help the user to understand why the code is being diagnosed. Also, does printing the source text add any clarity? The diagnostic already appears on the line in which the assembly statement appears, and since this is a statement (rather than an expression), it seems unlikely to be useful to repeat that text.
Agreed. Fixed.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:156
+   safety-no-assembler
+   safety-no-vector-bool
----------------
idlecode wrote:
> `safety-no-vector-bool` seems to belong to the other patch.
Well spotted. Thought I'd got rid of all of those.


https://reviews.llvm.org/D29267





More information about the cfe-commits mailing list