[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes
Dylan McKay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 5 16:41:23 PST 2017
dylanmckay updated this revision to Diff 87174.
dylanmckay marked 2 inline comments as done.
dylanmckay added a comment.
Code review
- Remove support for ObjC methods. We shouldn't do this as it doesn't really make sense
- Move some tests to `Sema`
- Don't attach invalid attributes when it isn't invalid
https://reviews.llvm.org/D28451
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/avr/attributes/interrupt.c
test/CodeGen/avr/attributes/signal.c
test/Sema/avr-interrupt-attr.c
test/Sema/avr-signal-attr.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28451.87174.patch
Type: text/x-patch
Size: 7767 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170206/61027bc8/attachment.bin>
More information about the cfe-commits
mailing list