[PATCH] D29393: [clang-tidy] Don't warn about call to unresolved operator*

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a minor nit that can be fixed without further review.



================
Comment at: test/clang-tidy/misc-unconventional-assign-operator.cpp:92
+enum E { e };
+E operator*(E, E);
+
----------------
You should put a comment near here to explain why this is a necessary part of the test.

Also, when fixing PRs, it's sometimes helpful to put the entire test into a namespace named after the PR (so people can do historical tracking a bit more easily). e.g., `namespace pr31531`. We've not done this often for clang-tidy, but it's quite common in clang's tests and might be a nice habit to get into -- it helps reduce accidental name collisions as a benefit.


https://reviews.llvm.org/D29393