[PATCH] D29135: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 1/3.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 4 14:52:13 PST 2017


EricWF added a comment.

Since all of these changes are for libc++ specific tests I would much rather see changes of this form:

  #if defined(_LIBCPP_VERSION)
  {
    typedef foo bar;
    static_assert(baz, "");
  }
  #endif

I think that's a lot nicer than wrapping every statement in the block in a `LIBCPP_ONLY`.
If you agree feel free to commit those changes without review.


https://reviews.llvm.org/D29135





More information about the cfe-commits mailing list