[PATCH] D29267: [clang-tidy] safety-no-assembler

Jonathan B Coe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 4 02:43:44 PST 2017


jbcoe planned changes to this revision.
jbcoe added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/safety-no-assembler.cpp:2
+// RUN: %check_clang_tidy %s safety-no-assembler %t
+
+void f() {
----------------
idlecode wrote:
> Maybe this check should handle `FileScopeAsmDecl` and `AsmLabelAttr` too?
> 
> ```
> __asm__(".symver foo, bar at v");
> static int s asm("spam");
> ```
Agreed.


https://reviews.llvm.org/D29267





More information about the cfe-commits mailing list