[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 3 13:59:51 PST 2017


vsk marked an inline comment as done.
vsk added a comment.

In https://reviews.llvm.org/D29369#666308, @vsk wrote:

> In https://reviews.llvm.org/D29369#665878, @filcab wrote:
>
> > Why the switch to `if` instead of a fully-covered switch/case?
>
>
> It lets me avoid repeating two function calls:


Ah, sorry about that, I think I understand what you had in mind now. I'll fix that too.


https://reviews.llvm.org/D29369





More information about the cfe-commits mailing list