[PATCH] D29393: [clang-tidy] Don't warn about call to unresolved operator*

Paweł Żukowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 3 10:16:02 PST 2017

idlecode added inline comments.

Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:63
+            cxxOperatorCallExpr(argumentCountIs(1),
+                                callee(unresolvedLookupExpr()),
+                                hasArgument(0, cxxThisExpr())))))));
Seems that it will catch all unary operators with ##this## as first argument.
e.g. in case `operator-` is defined somewhere, check will not warn about returning `-this`.
Do you think adding `hasOverloadedOperatorName("*")` for such abstract case is worth it?


More information about the cfe-commits mailing list