[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

[John McCall via Phabricator via cfe-commits]

rjmccall requested changes to this revision.
rjmccall added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/CodeGen/CGClass.cpp:1135
         MemberExpr *ME2 = dyn_cast<MemberExpr>(RHS);
-        if (dyn_cast<FieldDecl>(ME2->getMemberDecl()) != Field)
+        if (!ME2 || dyn_cast<FieldDecl>(ME2->getMemberDecl()) != Field)
           return nullptr;
----------------
I would prefer:

  if (MemberExpr *ME2 = dyn_cast<MemberExpr>(RHS)) {
    if (ME2->getMemberDecl() == Field)
      return Field;
  }
  return nullptr;


https://reviews.llvm.org/D29208