[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 1 03:58:50 PST 2017

a.sidorin added a comment.

Hi Gabor. One of the bugs fixed in this patch is still present in master, other two are already fixed.

Comment at: lib/AST/ASTImporter.cpp:2749
   // Create the imported function.
+  SourceLocation StartLoc = Importer.Import(D->getInnerLocStart());
   TypeSourceInfo *TInfo = Importer.Import(D->getTypeSourceInfo());
This chunk should be fixed by r236012.

Comment at: lib/AST/ASTImporter.cpp:3310
+  for (SourceLocation &Loc : SelLocs)
+    Loc = Importer.Import(Loc);
Still actual.

Comment at: lib/AST/ASTImporter.cpp:4613
+  return ToContext.getTrivialTypeSourceInfo(
+      T, Import(FromTSI->getTypeLoc().getLocStart()));
Fixed by r241542.


More information about the cfe-commits mailing list