[PATCH] D29358: [OpenMP] Report an error for -faltivec on anything other than PowerPC.

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

gtbercea created this revision.
Herald added a subscriber: nemanjai.

When performing an offload, throw an error if the host tool chain uses the altivec flag on an architecture other than PowerPC.


Repository:
  rL LLVM

https://reviews.llvm.org/D29358

Files:
  lib/Driver/Tools.cpp
  test/OpenMP/offloading_defects.cpp


Index: test/OpenMP/offloading_defects.cpp
===================================================================
--- /dev/null
+++ test/OpenMP/offloading_defects.cpp
@@ -0,0 +1,73 @@
+// #############################################################################
+// RUN:   %clangxx -DCK1 -target powerpc64le-ibm-linux-gnu -mcpu=pwr8 -maltivec -O0 -S -emit-llvm %s -o - \
+// RUN:   | FileCheck --check-prefix CK1 %s
+#ifdef CK1
+
+static __inline__ vector float __attribute__((__overloadable__, __always_inline__)) vec_ld(int __a,
+                                                   const vector float *__b) {
+  return (vector float)__builtin_altivec_lvx(__a, __b);
+}
+
+static __inline__ vector float __attribute__((__overloadable__, __always_inline__)) vec_ld(int __a, const float *__b) {
+  return (vector float)__builtin_altivec_lvx(__a, __b);
+}
+
+static __inline__ vector double __attribute__((__overloadable__, __always_inline__)) __builtin_vec_splats(double __a) {
+  return (vector double)(__a);
+}
+
+static __inline__ vector double __attribute__((__overloadable__, __always_inline__)) vec_abs(vector double __a) {
+  return __builtin_vsx_xvabsdp(__a);
+}
+
+static __inline__ vector bool long long __attribute__((__overloadable__, __always_inline__))
+vec_cmpgt(vector double __a, vector double __b) {
+  return (vector bool long long)__builtin_vsx_xvcmpgtdp(__a, __b);
+}
+
+static __inline__ vector double __attribute__((__overloadable__, __always_inline__))
+vec_sel(vector double __a, vector double __b, vector bool long long __c) {
+  vector long long __res = ((vector long long)__a & ~(vector long long)__c) |
+                           ((vector long long)__b & (vector long long)__c);
+  return (vector double)__res;
+}
+
+static __inline__ vector double __attribute__((__overloadable__, __always_inline__))
+vec_sel(vector double __a, vector double __b, vector unsigned long long __c) {
+  vector long long __res = ((vector long long)__a & ~(vector long long)__c) |
+                           ((vector long long)__b & (vector long long)__c);
+  return (vector double)__res;
+}
+
+static double x[8];
+
+static inline __vector double vec_ld_dbl(int offset, double const *x) {
+
+return (__vector double)vec_ld(offset,
+          reinterpret_cast<float*>(const_cast<double*>(x)));
+}
+
+// CK1: declare <4 x i32> @llvm.ppc.altivec.lvx(i8*)
+// CK1: declare <2 x i64> @llvm.ppc.vsx.xvcmpgtdp(<2 x double>, <2 x double>)
+// CK1: declare <2 x double> @llvm.fabs.v2f64(<2 x double>)
+
+int main(int argc, char **argv)
+{
+  double A[1] = {-1.0};
+
+  // FIXME: Test with OpenMP offloading support too.
+  #pragma omp target
+  {
+    A[0] += 1.0;
+  }
+
+  __vector double vsum = __builtin_vec_splats(A[0]);
+  __vector double verror = __builtin_vec_splats((double) 0.0);
+  __vector double v = vec_ld_dbl(0, x);
+  __vector bool long long sel = vec_cmpgt( vec_abs(v), vec_abs(vsum) );
+  __vector double a = vec_sel(vsum, v, sel);
+
+
+  return 0;
+}
+#endif
Index: lib/Driver/Tools.cpp
===================================================================
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -5432,7 +5432,10 @@
 
   // Report an error for -faltivec on anything other than PowerPC.
   if (const Arg *A = Args.getLastArg(options::OPT_faltivec)) {
-    const llvm::Triple::ArchType Arch = getToolChain().getArch();
+    const llvm::Triple::ArchType Arch =
+        JA.isDeviceOffloading(Action::OFK_None)
+            ? getToolChain().getArch()
+            : C.getSingleOffloadToolChain<Action::OFK_Host>()->getArch();
     if (!(Arch == llvm::Triple::ppc || Arch == llvm::Triple::ppc64 ||
           Arch == llvm::Triple::ppc64le))
       D.Diag(diag::err_drv_argument_only_allowed_with) << A->getAsString(Args)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29358.86513.patch
Type: text/x-patch
Size: 3748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170131/58916627/attachment.bin>