[PATCH] D29322: [clang-format] Fix regression merging comments across newlines.

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 31 04:53:32 PST 2017


krasimir marked an inline comment as done.
krasimir added inline comments.


================
Comment at: lib/Format/BreakableToken.cpp:685
     LineTok = CurrentTok->Next;
+    if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+      // A line comment section needs to broken by a line comment that is
----------------
krasimir wrote:
> klimek wrote:
> > Could we put them as children into the higher level UnwrappedLine instead?
> Putting them as children looks cleaner; will try that.
For now, I'm adding a FIXME, since this putting the sections into children has some undesired ripple effects in other places and needs more in-depth analysis.


https://reviews.llvm.org/D29322





More information about the cfe-commits mailing list