[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 28 20:09:10 PST 2017


dexonsmith updated this revision to Diff 86193.
dexonsmith added a comment.

I've rebased the patch on ToT and cleaned a few things up.

Sadly, the clang/test/Modules/diagnostic-options-out-of-date.m test fails because r293123 makes the command-line diagnostic options affect the AST, and thus makes -Wconversion vs -Wno-conversion change ASTFileSignature.

I'm not sure how to move forward.


https://reviews.llvm.org/D27689

Files:
  clang/include/clang/AST/ExternalASTSource.h
  clang/include/clang/Basic/Module.h
  clang/include/clang/Driver/CC1Options.td
  clang/include/clang/Frontend/PCHContainerOperations.h
  clang/include/clang/Lex/HeaderSearchOptions.h
  clang/include/clang/Serialization/ASTBitCodes.h
  clang/include/clang/Serialization/ASTReader.h
  clang/include/clang/Serialization/ASTWriter.h
  clang/include/clang/Serialization/Module.h
  clang/lib/Basic/Module.cpp
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp
  clang/lib/Frontend/ASTUnit.cpp
  clang/lib/Frontend/CompilerInstance.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/lib/Serialization/ASTReader.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/lib/Serialization/GeneratePCH.cpp
  clang/lib/Serialization/GlobalModuleIndex.cpp
  clang/test/Modules/diagnostic-options-out-of-date.m
  clang/test/Modules/module_file_info.m
  clang/test/Modules/rebuild.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27689.86193.patch
Type: text/x-patch
Size: 49669 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170129/3e07afa8/attachment-0001.bin>


More information about the cfe-commits mailing list