[PATCH] D27810: Normalize all filenames before searching FileManager caches

[Erik Verbruggen via Phabricator via cfe-commits]

erikjv added inline comments.


================
Comment at: lib/Basic/FileManager.cpp:218
+#ifdef LLVM_ON_WIN32
+  SmallString<128> NormalizedPath(Filename.str());
+  llvm::sys::path::native(NormalizedPath);
----------------
yaron.keren wrote:
> I'd use a larger SmallString<256>, with large projects 128 bytes are frequently not enough.
Well, the calling sides often use 128, so that's why I stuck with it.


https://reviews.llvm.org/D27810