[PATCH] D29198: clang-cl: Warn about /U flags that look like filenames (PR31662)

Adrian McCarthy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 26 14:42:41 PST 2017


amccarth added inline comments.


================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:252
+  InGroup<DiagGroup<"slash-u-filename">>;
+def note_use_dashdash : Note<"Use '--' to treat subsequent arguments as filenames">;
+
----------------
For Windows, wouldn't it make more sense to suggest using valid paths (with backslashes instead of slashes)?

What about all the other characters paths can begin with?  Shouldn't we also warn that /code/myproject will also be interpreted as /c rather than \code\myproject?


https://reviews.llvm.org/D29198





More information about the cfe-commits mailing list