[PATCH] D29151: [clang-tidy] Add misc-invalidated-iterators check.

[Piotr Padlewski via Phabricator via cfe-commits]

Prazek added a comment.

In https://reviews.llvm.org/D29151#656887, @Eugene.Zelenko wrote:

> General question: isn't Static Analyzer is better place for such workflow checks?


Probably yes, but it is much harder to implement this there. Other problem is that it would be probably a part 
of one of the alpha checks, that are not developed and I don't know if they will ever be fully supported.



================
Comment at: clang-tidy/misc/InvalidatedIteratorsCheck.h:35
+
+  // Returns the clang-tidy matcher binding to the possibly invalidating uses
+  // of the container (either invoking a dangerous member call or calling
----------------
drop clang-tidy. It's cleaner


================
Comment at: clang-tidy/misc/InvalidatedIteratorsCheck.h:37
+  // of the container (either invoking a dangerous member call or calling
+  // another function with a non-const reference.)
+  ExprMatcherType getModifyingMatcher(const VarDecl *VectorDecl);
----------------
).


Repository:
  rL LLVM

https://reviews.llvm.org/D29151