[PATCH] D21675: New ODR checker for modules

Richard Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 25 14:25:51 PST 2017


rsmith added a comment.

In https://reviews.llvm.org/D21675#654659, @teemperor wrote:

> Would be nice if we could make Stmt::Profile, ODRHash and the CloneDetection use the same backend.


This code is *already* reusing the Stmt::Profile code for hashing of statements. Why was a different mechanism invented for `CloneDetection`? If it doesn't have different requirements, maybe it should be rewritten in terms of the `Stmt::Profile` implementation too.


https://reviews.llvm.org/D21675





More information about the cfe-commits mailing list