[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 22:04:53 PST 2017


mehdi_amini added a comment.

In https://reviews.llvm.org/D29065#654336, @steven_wu wrote:

> I think you should add a new API for embedBitcodeMarkerEnabled() or revert the name the APIs to before https://reviews.llvm.org/rL287084.


I'm missing where https://reviews.llvm.org/rL287084 changed the name? It introduced a new API but didn't rename anything AFAICT, here is what it was before:

  bool embedBitcodeEnabled() const { return BitcodeEmbed == EmbedBitcode; }
  bool embedBitcodeEnabled() const { return BitcodeEmbed != EmbedNone; }


https://reviews.llvm.org/D29065





More information about the cfe-commits mailing list