[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 20:13:20 PST 2017


mehdi_amini added inline comments.


================
Comment at: clang/include/clang/CodeGen/BackendUtil.h:51
+  llvm::Expected<llvm::BitcodeModule>
+  FindThinLTOModule(llvm::MemoryBufferRef MBRef);
 }
----------------
Indentation seems strange?


================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:841
 
+std::unique_ptr<llvm::Module> CodeGenAction::loadModule(MemoryBufferRef MBRef) {
+  CompilerInstance &CI = getCompilerInstance();
----------------
Can you extract this function in a separate patch? I feel the diff could be a lot more contained here.



https://reviews.llvm.org/D29067





More information about the cfe-commits mailing list