[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

Dimitry Andric via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 14:32:42 PST 2017


dim added a comment.

In https://reviews.llvm.org/D28981#653908, @mclow.lists wrote:

> > In https://reviews.llvm.org/rL279744, __throw_XXX() functions were introduced, partially for compatibility with software compiled against libstdc++.
>
> You're working from a false premise.  These functions were not added for compatibility with libstdc++, but rather to encapsulate the mechanism for throwing an exception - to localize the changes needed to support `-fno-exceptions`


Ok, I was mistaken about the premise, but by accident (or by their self-evidentness) the names are still shared with the GNU names.  It would be nice to have some way of making them semi-compatible.  Alternatively, we could rename them, but that would be more churn, I guess.


https://reviews.llvm.org/D28981





More information about the cfe-commits mailing list