[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 12:58:58 PST 2017


efriedma added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:4031
   // C99 6.5.3.4p4: the type (an unsigned integer type) is size_t.
+  if (isUnevaluatedContext() && ExprKind == UETT_SizeOf &&
+      TInfo->getType()->isVariablyModifiedType())
----------------
Is the isUnevaluatedContext() check here necessary?


================
Comment at: test/SemaCXX/pr31042.cpp:1
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -emit-obj -disable-free %s
+
----------------
-emit-obj ?


================
Comment at: test/SemaCXX/pr31042.cpp:3
+
+extern void abort (void);
+
----------------
Is this declaration necessary somehow?


https://reviews.llvm.org/D27800





More information about the cfe-commits mailing list