[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 23 11:00:24 PST 2017


yaxunl added a comment.

The tests should be added to SemaOpenCL/extension-version.cl



================
Comment at: lib/Sema/SemaType.cpp:6683
+  // access qualifier unless the cl_khr_3d_image_writes extension is enabled.
+  if (CurType->isOCLImage3dWOType() &&
+      !S.getOpenCLOptions().isEnabled("cl_khr_3d_image_writes")) {
----------------
should modify OpenCLImageTypes.def for image types associated with an extension. The diagnostics will be emitted automatically.


https://reviews.llvm.org/D28860





More information about the cfe-commits mailing list