[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

Jonathan Roelofs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 18 13:11:05 PST 2017


jroelofs added a comment.

In https://reviews.llvm.org/D28820#649770, @efriedma wrote:

> > There would be a big performance penalty for ISRs with callees that don't use VFP regs.
>
> Sacrificing correctness for the sake of performance seems like a bad idea...


I don't quite see it that way, but I understand where you're coming from.

> especially given that the optimizer can insert calls to memcpy where they didn't originally exist in the source.

That, however, is the nail in the coffin of my argument :)


https://reviews.llvm.org/D28820





More information about the cfe-commits mailing list