[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

[Alexey Bataev via cfe-commits]

Armpit, fine, leave it as is

Best regards,
Alexey Bataev

> 18 янв. 2017 г., в 15:50, Arpith Jacob via Phabricator <reviews at reviews.llvm.org> написал(а):
> 
> arpith-jacob added inline comments.
> 
> 
> ================
> Comment at: lib/Sema/SemaOpenMP.cpp:1933-1937
> +  StmtResult SR = S;
> +  int ThisCaptureLevel =
> +      getOpenMPCaptureLevels(DSAStack->getCurrentDirective());
> +  while (--ThisCaptureLevel >= 0)
> +    SR = ActOnCapturedRegionEnd(SR.get());
> ----------------
> ABataev wrote:
>> Could you move this code to `CaptureRegionUnwinderRAII`?
> Hi Alexey, this code will be expanded in the next patch.  Have a look at:
> https://reviews.llvm.org/D28781
> SemaOpenMP.cpp:1930.
> This is the code to codegen preinits.  I think that code doesn't belong to the RAII.  That's why I haven't moved this code to CaptureRegionUnwinderRAII.
> 
> Let me know if you disagree.
> 
> 
> https://reviews.llvm.org/D28753
> 
> 
>