[PATCH] D28725: [libc++][CMake] Use debug MSVC runtimes when libc++ is built in debug mode

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added a comment.

Awesome. LGTM except that force-removing the `_DEBUG` define and then linking against the debug libraries might cause some wonkiness.



================
Comment at: CMakeLists.txt:394
 # non-debug DLLs
 remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
 
----------------
We should be able to remove this now, right?


https://reviews.llvm.org/D28725