[PATCH] D28716: [libc++] Diagnose null inputs in std::string using _LIBCPP_DIAGNOSE_WARNING

[Noel Grandin via Phabricator via cfe-commits]

grandinj added a comment.

would it be better to internally treat __attribute__((non_null)) like diagnose_if ? then you get all the warnings for free?


https://reviews.llvm.org/D28716