[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 12 14:27:46 PST 2017


tejohnson added a comment.

In https://reviews.llvm.org/D28588#644467, @danielcdh wrote:

> The breaks some buildbots thus I reverted the patch:
>
> http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/1889
>  http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/32242/
>
> Unfortunately I could not reproduce the error locally.
>
> Any quick insights why this test change would break?


Looks like there was no output (at least on the buildbot that I looked at). Most likely because this is using debug output and perhaps those are build NDEBUG? I wonder if there is a better way to test this. Otherwise I think "; REQUIRES: asserts" might do the trick?

> Thanks,
> Dehao




https://reviews.llvm.org/D28588





More information about the cfe-commits mailing list