[PATCH] D28591: [libcxx] [test] Don't ask whether Incomplete& can be assigned to.

Stephan T. Lavavej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 11 19:03:35 PST 2017


STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

[libcxx] [test] Don't ask whether Incomplete& can be assigned to.

This is the subject of an active NB comment. Regardless of what the Working
Paper currently says, asking this question is morally wrong, because the
answer can change when the type is completed. C1XX now detects such
precondition violations and complains about them; perhaps Clang should too.


https://reviews.llvm.org/D28591

Files:
  test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp


Index: test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp
===================================================================
--- test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp
+++ test/std/utilities/meta/meta.unary/meta.unary.prop/is_assignable.pass.cpp
@@ -82,5 +82,4 @@
 
 //  pointer to incomplete template type
 	test_is_assignable<X<D>*&, X<D>*> ();
-    test_is_not_assignable<Incomplete&, Incomplete const&>();
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28591.84066.patch
Type: text/x-patch
Size: 472 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170112/05093a9b/attachment-0001.bin>


More information about the cfe-commits mailing list