[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

[Dylan McKay via Phabricator via cfe-commits]

dylanmckay added inline comments.


================
Comment at: include/clang/Basic/Attr.td:488
+
+def AVRSignal : InheritableAttr, TargetSpecificAttr<TargetAVR> {
+  let Spellings = [GNU<"signal">];
----------------
aaron.ballman wrote:
> Does this attribute appertain to any specific subjects, or can you apply it to any declaration?
It can be applied to function definitions only.


================
Comment at: test/CodeGen/avr/attributes/naked.c:4
+// CHECK: define void @foo() #0
+__attribute__((naked)) void foo(void) { }
+
----------------
aaron.ballman wrote:
> This test seems unrelated as you didn't modify anything about the naked attribute?
I didn't modify the naked attribute, but I did want to include a test for AVR.


https://reviews.llvm.org/D28451