[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 10 18:18:42 PST 2017
thakis added a comment.
Thanks! Can you add a test somewhere? `grep -R W.*uninitialized test/Sema*` will probably show you the existing test for this code. (Another technique: Comment some of the existing tests, run `ninja check-clang`, and see which tests start failing.)
You can run an individual test via `bin/llvm-lit ../../llvm/tools/clang/test/Sema/mytest.cc`.
================
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:907
else
DiagUninitUse(S, VD, Use, true);
}
----------------
Should the check be in DiagUninitUse()? Or is there a reason this one should happen for volatiles?
https://reviews.llvm.org/D28543
More information about the cfe-commits
mailing list