[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: docs/UsersManual.rst:2003
+     $ clang -target nvptx64-unknown-unknown test.cl
+     $ clang -target amdgcn-unknown-amdhsa test.cl
+
----------------
$ clang -target amdgcn-amd-amdhsa-opencl test.cl


================
Comment at: docs/UsersManual.rst:2053
+
+Disables standard target extensions. All OpenCL targets provide a list
+of extensions that they support. Clang allows to amend this using the ``-cl-ext``
----------------
Maybe rephrase as "Disables support of OpenCL extensions" instead of "Disable standard target extensions" since "standard target extension" is confusing and also to avoid confusion with the effect of disabling OpenCL extension as in '#pragam OPENCL EXTENSION X: disable'. Disabling support of an extension means that they cannot be enabled by pragmas in the OpenCL kernels since they are deemed as non-supported.


================
Comment at: docs/UsersManual.rst:2107
+
+     $ clang -target -triple amdgcn-unknown-amdhsa test.cl
+
----------------
$ clang -target amdgcn-amd-amdhsa-opencl test.cl


================
Comment at: docs/UsersManual.rst:2154
+and modules (:doc:`Modules`) are used internally to improve the compilation
+speed.
+
----------------
To enable modules for OpenCL, add option `-fmodules -fimplicit-module-maps -fmodules-cache-path=X` where X is the directory for storing the generated modules.


https://reviews.llvm.org/D28080