[PATCH] D28315: Update tools to use new getStyle API
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 9 01:38:33 PST 2017
ioeric added a comment.
I ran `ninja check-all` with https://reviews.llvm.org/D28081 and https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed, namely:
Clang :: Format/style-on-command-line.cpp
Clang Tools :: clang-apply-replacements/basic.cpp
Clang Tools :: clang-apply-replacements/conflict.cpp
Clang Tools :: clang-apply-replacements/crlf.cpp
Clang Tools :: clang-apply-replacements/format.cpp
Clang Tools :: clang-rename/ClassReplacements.cpp
Error message I am seeing: `Expected<T> must be checked before access or destruction.`
Could you double check? Thanks!
================
Comment at: change-namespace/ChangeNamespace.cpp:892
+ llvm::errs() << llvm::toString(Style.takeError()) << "\n";
+ continue;
+ }
----------------
I'd still like to apply replacements that are not cleaned up. Could you add the following line before continue, thanks! :)
```
FileToReplacements[FilePath] = Replaces;
```
https://reviews.llvm.org/D28315
More information about the cfe-commits
mailing list