[PATCH] D28018: AMD family 17h (znver1) enablement

Ganesh Gopalasubramanian via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 8 12:33:03 PST 2017


GGanesh added inline comments.


================
Comment at: lib/Basic/Targets.cpp:3189
     break;
+  case CK_ZNVER1:
+    setFeatureEnabledImpl(Features, "adx", true);
----------------
RKSimon wrote:
> Same as what I asked on D28017 - is there an accepted order that we should be using here?
Some of them seems to be chronological.
Some of them are alphabetical.

I personally don't have any preference as such.
Alphabetical order suits a long list. 
I would like to know your suggestion.


https://reviews.llvm.org/D28018





More information about the cfe-commits mailing list