[PATCH] D28344: [AVR] Add support for the full set of inline asm constraints

Dylan McKay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 6 21:42:05 PST 2017


dylanmckay marked an inline comment as done.
dylanmckay added inline comments.


================
Comment at: lib/Basic/Targets.cpp:8506
+      case 'N': // Integer constant (Range: -1)
+        Info.setRequiresImmediate(-1);
+      case 'O': // Integer constant (Range: 8, 16, 24)
----------------
ahatanak wrote:
> Is this meant to fall through or do you need a "break" here?
Nice catch, fixed


https://reviews.llvm.org/D28344





More information about the cfe-commits mailing list