[PATCH] D26949: [libc++abi] Clean up visibility

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 6 20:21:55 PST 2017


compnerd added inline comments.


================
Comment at: src/cxa_new_delete.cpp:34
 */
-__attribute__((__weak__, __visibility__("default")))
+__attribute__((__weak__))
 void *
----------------
EricWF wrote:
> Can we abstract this away to a `_LIBCXXABI_NEW_DELETE_VIS` macro?
Are `operator new` and `operator delete` the only functions that will ever need weak linkage?  I think that using a more generic macro would be nicer.  `_LIBCXXABI_WEAK_LINKAGE` perhaps?


https://reviews.llvm.org/D26949





More information about the cfe-commits mailing list