[PATCH] D28426: [libc++] Tolerate presence of __deallocate macro
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 6 17:46:00 PST 2017
EricWF added a comment.
In https://reviews.llvm.org/D28426#638596, @smeenai wrote:
> I'm guessing always defining `_LIBCPP_DISABLE_MACRO_CONFLICT_WARNINGS` on Windows isn't considered an acceptable workaround either?
Not really, since that still breaks users of the `__deallocate` since we `#undef` it.
PS. I think Windows is the only platform where `__deallocate` is an issue, so defining `_LIBCPP_DISABLE_MACRO_CONFLICT_WARNINGS` on Windows just makes the warnings dead code on all platforms.
https://reviews.llvm.org/D28426
More information about the cfe-commits
mailing list