[PATCH] D28220: provide Win32 native threading

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 6 16:34:42 PST 2017


EricWF added inline comments.


================
Comment at: include/__threading_support:29
+#include <assert.h>
+#define WIN32_LEAN_AND_MEAN
+#include <Windows.h>
----------------
I think we agreed that we cannot use this macro.


================
Comment at: include/__threading_support:426
+// Condition Variable
+_LIBCPP_ALWAYS_INLINE
+int __libcpp_condvar_signal(__libcpp_condvar_t *__cv)
----------------
DO NOT ANNOTATE THESE DEFINITIONS!! The forward declarations are already properly declared.


Repository:
  rL LLVM

https://reviews.llvm.org/D28220





More information about the cfe-commits mailing list