[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

don hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 6 09:05:45 PST 2017


hintonda added inline comments.


================
Comment at: clang-tidy/modernize/UseNoexceptCheck.h:19
+
+using CandidateSet = llvm::StringSet<llvm::MallocAllocator>;
+
----------------
malcolm.parsons wrote:
> Unused?
Good catch -- left over from a previous version.


================
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:38
+
+Please note that since ``throw(int)`` is equivelent to
+``noexcept(false)`` not ``noexcept``, this check will detect, but not
----------------
malcolm.parsons wrote:
> typo: equivelent -> equivalent.
Thanks!  Spelling isn't my strong suit.


https://reviews.llvm.org/D20693





More information about the cfe-commits mailing list