[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

[Manman Ren via Phabricator via cfe-commits]

manmanren added inline comments.


================
Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:131
+  "diagnostic options now it is a non-system module">,
+  InGroup<ModuleConflict>;
+
----------------
aprantl wrote:
> Is this better?
> 
> "module file '%0' was validated as a system module and is now being imported as a non-system module; any differences in diagnostics options will be ignored"
Thanks Adrian. Your wording sounds better.


================
Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:135
+  "module file '%0' was validated in an ancestor thread, now it needs to "
+  "be invalidated">;
+
----------------
aprantl wrote:
> I wonder if there is a way to rephrase this message such that an end-user could understan how to interpret this error?
I am not sure if we will emit this error diagnostic in some case, that is why I don't have a testing case. Maybe it is better to throw a hard error instead of a diagnostic that user can't understand?



https://reviews.llvm.org/D28299