[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Samuel Antao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 5 04:49:45 PST 2017


sfantao marked an inline comment as done.
sfantao added a comment.

Hi Jonas,

Thanks for the review.



================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252
+      // \brief Flags associated the device global.
+      int32_t Flags;
+
----------------
Hahnfeld wrote:
> Is that intentionally not in the `protected` section below?
Yes, we have a public getter/setter to interact with that, so no need to make it protected.  


https://reviews.llvm.org/D28298





More information about the cfe-commits mailing list