[PATCH] D28131: [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 22:16:02 PST 2017


EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D28131#632516, @vsk wrote:

> LGTM. I'm not sure what to do for a test. Have you tried checking the IR for the affected object file in tablegen at '-O2 -fsanitize=undefined'? If there's an unconditional call to the ubsan handler, maybe the tablegen source could be used to find a small reproducer?


Good idea. I'll have to try that, however I'll try to write a test post-commit.


https://reviews.llvm.org/D28131





More information about the cfe-commits mailing list