[PATCH] D28253: static_assert inside make_shared when the object is not constructible

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 4 14:45:15 PST 2017


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM minus the `config.py` changes, but those were discussed offline.

Also I prefer to write new `.fail.cpp` tests using clang verify. It allows fail tests to contain more than one test case, and it verifies the diagnostic messages omitted. I re-wrote your two failure tests as a single test using `-verify` here <https://gist.github.com/EricWF/e328af953a34df6af5070788f600e8bb>.


https://reviews.llvm.org/D28253





More information about the cfe-commits mailing list