[PATCH] D27486: Correct class-template deprecation behavior

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:322
+      CXXThisScopeRAII ThisScope(*this, ThisContext, /*TypeQuals*/ 0,
+                                 ND && ND->isCXXInstanceMember());
+
----------------
No need to check for `ND` here; already done above. You might also want to remove `ThisContext` and just sink the initialization.


================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:2520
+     << "        const MultiLevelTemplateArgumentList &TemplateArgs) {\n";
+  EmitClangAttrTemplateInstantiateHelper(Attrs, OS, /*DeclTime=*/false);
+  OS << "}\n\n"
----------------
DeclTime -> AppliesToDecl


================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:2525
+     << "        const MultiLevelTemplateArgumentList &TemplateArgs) {\n";
+  EmitClangAttrTemplateInstantiateHelper(Attrs, OS, /*DeclTime=*/true);
+
----------------
DeclTime -> AppliesToDecl


https://reviews.llvm.org/D27486