[PATCH] D28287: [clang-tidy] Ignore default arguments in modernize-default-member-init

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

Btw, when creating a patch, it's helpful to the reviewers (especially ones who are only casually interested) to put some of the context from the bug report into the patch summary rather than only list the PR.



================
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:161
             cxxBoolLiteral(), cxxNullPtrLiteralExpr(), implicitValueInitExpr(),
-            declRefExpr());
+            declRefExpr(unless(to(varDecl()))));
 
----------------
Any `varDecl`? Or do we want to limit it to only `parmVarDecl` instead?
```
int i = 12;
struct S {
  int j;
  S() : j(i) {}
};
```
It seems reasonable to suggest the member initialization be "fixed" to: `int j = i;`


https://reviews.llvm.org/D28287