[PATCH] D28081: Make GetStyle return Expected<FormatStyle> instead of FormatStyle

[Antonio Maiorano via Phabricator via cfe-commits]

amaiorano added a comment.

In https://reviews.llvm.org/D28081#633786, @ioeric wrote:

> The patch LGTM now. I'll accept both this and the one for clang-tool-extra when it is ready.
>
> Regarding builbots, we have bots that continually run builds/tests (http://lab.llvm.org:8011/). Many buildbots test llvm and clang as well as clang-tools-extra (e.g. with `ninja check-all`) at some revision. Also note that although llvm/clang and clang-tools-extra are different repos, they do share the same revision sequence. So if clang-tools-extra is in a inconsistent state, many buildbots can fail and affect llvm/clang builds. Unfortunately, there is no atomic way to commit two revisions to two repositories, so we just commit them quickly one after another so that we do less damage. Do you have commit access to LLVM btw?


I do have commit access. I'll get to work on the clang-tools-extras and open a new review for it once it's ready. Thanks.


https://reviews.llvm.org/D28081