[PATCH] D27430: [libc++] Annotate template methods with visibility

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 19:44:34 PST 2017


smeenai added a comment.

In https://reviews.llvm.org/D27430#634882, @smeenai wrote:

> In https://reviews.llvm.org/D27430#634880, @smeenai wrote:
>
> > Sounds good to me for `_LIBCPP_HIDDEN`, but as far as I understand, for the `inline _LIBCPP_INLINE_VISIBILITY` cases, at least the `inline` needs to be at the definition itself, otherwise it won't have any effect.
>
>
> Err this might actually have just been me being stupid. Lemme confirm that first.


Yup, I'm dumb; ignore me. I'll move everything to the declarations.


https://reviews.llvm.org/D27430





More information about the cfe-commits mailing list