[PATCH] D28274: [MS] Instantiate default args during instantiation of exported default ctors

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 18:58:56 PST 2017


rnk created this revision.
rnk added a reviewer: rsmith.
rnk added a subscriber: cfe-commits.

Replace some old code that probably pre-dated the change to delay
emission of dllexported code until after the closing brace of the
outermost record type. Only uninstantiated default argument expressions
need to be handled now. It is enough to instantiate default argument
expressions when instantiating dllexported default ctors. This also
fixes some double-diagnostic issues in this area.

Fixes PR31500


https://reviews.llvm.org/D28274

Files:
  lib/Sema/SemaDeclCXX.cpp
  lib/Sema/SemaTemplateInstantiateDecl.cpp
  test/CodeGenCXX/dllexport.cpp
  test/SemaCXX/default-arg-closures.cpp
  test/SemaCXX/dllexport.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28274.82991.patch
Type: text/x-patch
Size: 9856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170104/a7aeaa0b/attachment-0001.bin>


More information about the cfe-commits mailing list