[PATCH] D28223: clean up use of _WIN32

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added inline comments.


================
Comment at: include/support/win32/support.h:113
 // Returns zero if no set bit is found.
-#if defined(_WIN64)
+#if defined(__LP64__)
   if (_BitScanForward64(&where, mask))
----------------
Windows wouldn't have `__LP64__` defined (since it's LLP64 anyway). According to MSDN `_BitScanForward64` is available on x64 and ARM, so the conditional should reflect that (i.e. the existing conditional was incorrect, but since you're changing it you may as well fix it).


================
Comment at: include/support/win32/support.h:153
 // Returns 0 if no set bit is found.
-#if defined(_WIN64)
+#if defined(__LP64__)
   if (_BitScanReverse64(&where, mask))
----------------
Same `__LP64__` comment here.


Repository:
  rL LLVM

https://reviews.llvm.org/D28223