[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr
Antonio Maiorano via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 3 08:16:31 PST 2017
amaiorano added a comment.
In https://reviews.llvm.org/D27440#634043, @cameron314 wrote:
> >> Thanks, I'll check these out! Btw, I noticed that the clang-format tests are non-Windows due to path assumptions. Is this a lost cause, or just something no one's bothered to look into yet?
> >
> > No one's bothered looking into it yet.
>
> Which tests? We run the unit tests (FormatTests.exe) locally just fine on Windows.
There was one test disabled for MSVC, which I fixed and enabled here: https://reviews.llvm.org/D27971
I will soon close this issue (https://reviews.llvm.org/D27440) once https://reviews.llvm.org/D28081 goes through as clang-format should return non-zero when an error occurs.
In https://reviews.llvm.org/D27440#634043, @cameron314 wrote:
> >> Thanks, I'll check these out! Btw, I noticed that the clang-format tests are non-Windows due to path assumptions. Is this a lost cause, or just something no one's bothered to look into yet?
> >
> > No one's bothered looking into it yet.
>
> Which tests? We run the unit tests (FormatTests.exe) locally just fine on Windows.
https://reviews.llvm.org/D27440
More information about the cfe-commits
mailing list